fix: Consider RPC channel health based on MQTT session #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the MQTT session for the health rather than the "subscription". It is straight foward to add a topic when sending an RPC so we assume we can do that on demand when sending the RPC.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the MQTT connection health check for RPC channels to rely solely on the MQTT session state rather than subscription status. The change aligns with the architecture where subscriptions are created on-demand when sending RPC commands.
Key changes:
- Removed subscription status check (
_mqtt_unsub is not None) fromis_mqtt_connectedproperty - Updated test assertions to reflect that MQTT can be considered connected without an active subscription
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| roborock/devices/v1_channel.py | Modified is_mqtt_connected property to check only the MQTT channel connection state, removing the subscription status requirement |
| tests/devices/test_v1_channel.py | Updated test assertion to expect MQTT connection to be considered healthy when the session is connected, even without an active subscription |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lash-L
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the MQTT session for the health rather than the "subscription". It is straight foward to add a topic when sending an RPC so we assume we can do that on demand when sending the RPC.
In practice, we don't actually use this for any health checking that is meaningful. However, it seems worth making consistent with our stance on this.